Skip to content

(Chore): Fix copy on welcome page#663

Merged
TylerJang27 merged 1 commit into
mainfrom
tyler/fix-welcome-misleading
May 14, 2026
Merged

(Chore): Fix copy on welcome page#663
TylerJang27 merged 1 commit into
mainfrom
tyler/fix-welcome-misleading

Conversation

@TylerJang27
Copy link
Copy Markdown
Contributor

Fingerprinting is not currently a quarantining input

@trunk-staging-io
Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 14, 2026

Claude finished @TylerJang27's task in 39s —— View job


Review

  • Read PR diff
  • Verify factual accuracy of copy change
  • Check grammar, formatting, and style

Summary

The change replaces an inaccurate sentence (which implied fingerprinting feeds into quarantine decisions) with corrected copy clarifying that fingerprinting is used for triage/surfacing differences, and quarantining is a separate mechanism. This matches the PR description: "Fingerprinting is not currently a quarantining input."

Findings

✅ Factual fix is correct and the previous wording (quarantine decisions "based on the actual failure pattern" + "if it fails in a new way, CI fails normally") is appropriately removed since that behavior isn't accurate.

✅ Sentence count reduces from 4 → 3, which tightens the paragraph without losing meaning.

✅ No typos, formatting, or markdown issues.

Minor style nit (non-blocking)welcome.md:31

We quarantine flaky tests so that if a quarantined test fails, CI passes.

The "so that … if … then" construction is slightly clunky and repeats "quarantine"/"quarantined". A tighter alternative:

We quarantine flaky tests, so their failures don't fail CI.

or

When a test is quarantined, its failures no longer fail CI.

Up to the author — the current wording is clear enough.
• Branch: tyler/fix-welcome-misleading

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: Claude code review passed.

@TylerJang27 TylerJang27 merged commit 19fa25d into main May 14, 2026
6 checks passed
@TylerJang27 TylerJang27 deleted the tyler/fix-welcome-misleading branch May 14, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant